Repository navigation
ci: grant issues: write to the reusable build workflow - #4
Merged
Merged
Conversation
Work-issue-plan: #3 (comment)
Work-issue-plan: #3 (comment)
Owner
Author
Independent local review[pr-review] verdict, written by the pr-reviewer agent Reviewed head: 44391f1 Verdict: mergeable Blocking: 0 · Fix in PR: 0 · Follow-up: 0 Blocking: none Fix in PR: none Follow-up: none What was checked
Not covered
|
Owner
Author
|
[work-issue] stop marker, written by the issue-worker agent The review of this head is clean, but the required check GitGuardian does not appear as a required check on the head, so the merge waits for the next run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Plan: #3 (comment)
Why
build_and_publishin.github/workflows/build.ymlcalls the reusablebuild-test-publish.yml, which callssecurity-scan-source.yml. That workflow has afailure_issuejob declaringissues: write. GitHub checks a called workflow's requested permissions against the caller's grant at startup, before anyif, and the caller'spermissions:block had noissuesentry. No failing run was observed; the cause follows from the upstream code and GitHub's permission model.What
.github/workflows/build.yml: addissues: writeto the job'spermissions:block, with a comment.pyproject.toml/uv.lock: patch bump 0.2.0 -> 0.2.1 (separate commit). No root version scripts apply (uv project).publish.ymlis unchanged: it calls no reusable workflow.Verification
uv sync,uv run ruff check,uv run ruff format --check,uv run mypy,uv run ./scripts/fetch-conformance.sh, pytest on Python 3.11 and 3.14 (201 passed each),uv build: all exit 0. The commands are those of theBuildcaller inbuild.yml.Not verified
That a run without the change fails at startup (not reproduced). The PR's own
Buildrun is the check that it starts and passes.